fix: accept string or number for analyze tool depth parameters#5444
Closed
tlongwell-block wants to merge 4 commits into
Closed
fix: accept string or number for analyze tool depth parameters#5444tlongwell-block wants to merge 4 commits into
tlongwell-block wants to merge 4 commits into
Conversation
…ent panics on invalid string input
Collaborator
Author
|
Closed in favor of #5478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
analyzetool in the developer MCP extension expects numeric parameters (max_depthandfollow_depth) as integers, but AI agents sometimes pass these as strings (e.g.,"2"instead of2), causing deserialization failures. This simple fix adds a flexible deserializer that accepts both formats, making the tool more forgiving and agent-friendly without changing its behavior—similar to how web forms accept both numeric and string inputs for number fields.